Fix docs build on Julia v1.12.2+ #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
After the build completes, the updated documentation will be available here |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Member
|
I think this is just because these changes haven't been released yet. I will try and have a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the docs build that broke on Julia v1.12.2 (see for example here). This was just caused by a stray space in the header link definition of the boundary MPS example, that Julia chose to stop ignoring just now. Removing the space fixes the build.
Not the point here but something to be looked at in the future: in the process I regenerated the boundary MPS example with updated package versions, and in particular the MPO and MPS printing in the most recent MPSKit.jl version doesn't look too good here. It's printing all the tensor map data now, which is really not what we want. In particular, this behavior seems very different to what was shown in QuantumKitHub/MPSKit.jl#341, which looked much better. Was there a more recent change in MPSKit.jl, TensorKit.jl (or even Julia) that could have lead to the overprinting here @lkdvos?
EDIT: never mind, QuantumKitHub/MPSKit.jl#341 is just not released yet, my bad.