-
Notifications
You must be signed in to change notification settings - Fork 25
Add double-layer-pepo reduced densitymatrix #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
We can test the functions using The reduced_densitymatrix(inds, ρ::InfinitePEPO, env::CTMRGEnv)where |
|
Yeah, I would definitely like to add both but this one was easier since it was more similar to the peps case. I’ll try generalize in a follow up PR if that’s ok? |
|
OK. For the tests, besides the physical example of Ising model, we can just generate a random PEPO and CTMRGEnv (no need to converge the env), and check the measurement results are the same as what we would obtain if we fuse the virtual legs and the physical legs respectively of the PEPO. |
27734f5 to
6999fd9
Compare
6999fd9 to
f3502db
Compare
|
That's a great point about the tests, thanks a lot, this really sped up the dev time for me. |
Yue-Zhengyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind if I make the tests a bit more strict (and some other minor changes)?
|
Feel free to make the changes, and I agree with your comments |
f3502db to
167ab9b
Compare
Yue-Zhengyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge for me once the tests pass.
Follow-up for #250 and #184:
I want to write reduced density matrices for
densitymatrix * densitymatrix'sandwiches, assuming that we'll obtain the CTMRG environments via fusing the InfinitePEPO into a InfinitePEPS construction.InfinitePEPOto fusedInfinitePEPSconverter@Yue-Zhengyuan if you have test cases laying around that would be wonderful