Skip to content

Add tests for polar decomposition for GPU #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 1 commit into from
Oct 16, 2025
Merged

Add tests for polar decomposition for GPU #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions test/amd/polar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
using MatrixAlgebraKit
using Test
using TestExtras
using StableRNGs
using LinearAlgebra: LinearAlgebra, I, isposdef, Hermitian
using MatrixAlgebraKit: PolarViaSVD
using AMDGPU

@testset "left_polar! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
rng = StableRNG(123)
m = 54
@testset "size ($m, $n)" for n in (37, m)
k = min(m, n)
svd_algs = (ROCSOLVER_QRIteration(), ROCSOLVER_Jacobi())
@testset "algorithm $svd_alg" for svd_alg in svd_algs
n < m && svd_alg isa ROCSOLVER_QRIteration && continue
A = ROCArray(randn(rng, T, m, n))
alg = PolarViaSVD(svd_alg)
W, P = left_polar(A; alg)
@test W isa ROCMatrix{T} && size(W) == (m, n)
@test P isa ROCMatrix{T} && size(P) == (n, n)
@test W * P ≈ A
@test isisometric(W)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

Ac = similar(A)
W2, P2 = @constinferred left_polar!(copy!(Ac, A), (W, P), alg)
@test W2 === W
@test P2 === P
@test W * P ≈ A
@test isisometric(W)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

noP = similar(P, (0, 0))
W2, P2 = @constinferred left_polar!(copy!(Ac, A), (W, noP), alg)
@test P2 === noP
@test W2 === W
@test isisometric(W)
P = W' * A # compute P explicitly to verify W correctness
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P))
@test isposdef(Hermitian(project_hermitian!(P)))
end
end
end

@testset "right_polar! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
rng = StableRNG(123)
n = 54
@testset "size ($m, $n)" for m in (37, n)
k = min(m, n)
svd_algs = (ROCSOLVER_QRIteration(), ROCSOLVER_Jacobi())
@testset "algorithm $svd_alg" for svd_alg in svd_algs
n > m && svd_alg isa ROCSOLVER_QRIteration && continue
A = ROCArray(randn(rng, T, m, n))
alg = PolarViaSVD(svd_alg)
P, Wᴴ = right_polar(A; alg)
@test Wᴴ isa ROCMatrix{T} && size(Wᴴ) == (m, n)
@test P isa ROCMatrix{T} && size(P) == (m, m)
@test P * Wᴴ ≈ A
@test isisometric(Wᴴ; side = :right)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

Ac = similar(A)
P2, Wᴴ2 = @constinferred right_polar!(copy!(Ac, A), (P, Wᴴ), alg)
@test P2 === P
@test Wᴴ2 === Wᴴ
@test P * Wᴴ ≈ A
@test isisometric(Wᴴ; side = :right)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

noP = similar(P, (0, 0))
P2, Wᴴ2 = @constinferred right_polar!(copy!(Ac, A), (noP, Wᴴ), alg)
@test P2 === noP
@test Wᴴ2 === Wᴴ
@test isisometric(Wᴴ; side = :right)
P = A * Wᴴ' # compute P explicitly to verify W correctness
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P))
@test isposdef(Hermitian(project_hermitian!(P)))
end
end
end
85 changes: 85 additions & 0 deletions test/cuda/polar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
using MatrixAlgebraKit
using Test
using TestExtras
using StableRNGs
using LinearAlgebra: LinearAlgebra, I, isposdef, Hermitian
using MatrixAlgebraKit: PolarViaSVD
using CUDA

@testset "left_polar! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
rng = StableRNG(123)
m = 54
@testset "size ($m, $n)" for n in (37, m)
k = min(m, n)
svd_algs = (CUSOLVER_QRIteration(), CUSOLVER_Jacobi())
@testset "algorithm $svd_alg" for svd_alg in svd_algs
n < m && svd_alg isa CUSOLVER_QRIteration && continue
A = CuArray(randn(rng, T, m, n))
alg = PolarViaSVD(svd_alg)
W, P = left_polar(A; alg)
@test W isa CuMatrix{T} && size(W) == (m, n)
@test P isa CuMatrix{T} && size(P) == (n, n)
@test W * P ≈ A
@test isisometric(W)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

Ac = similar(A)
W2, P2 = @constinferred left_polar!(copy!(Ac, A), (W, P), alg)
@test W2 === W
@test P2 === P
@test W * P ≈ A
@test isisometric(W)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

noP = similar(P, (0, 0))
W2, P2 = @constinferred left_polar!(copy!(Ac, A), (W, noP), alg)
@test P2 === noP
@test W2 === W
@test isisometric(W)
P = W' * A # compute P explicitly to verify W correctness
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P))
@test isposdef(Hermitian(project_hermitian!(P)))
end
end
end

@testset "right_polar! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
rng = StableRNG(123)
n = 54
@testset "size ($m, $n)" for m in (37, n)
k = min(m, n)
svd_algs = (CUSOLVER_QRIteration(), CUSOLVER_Jacobi())
@testset "algorithm $svd_alg" for svd_alg in svd_algs
n > m && svd_alg isa CUSOLVER_QRIteration && continue
A = CuArray(randn(rng, T, m, n))
alg = PolarViaSVD(svd_alg)
P, Wᴴ = right_polar(A; alg)
@test Wᴴ isa CuMatrix{T} && size(Wᴴ) == (m, n)
@test P isa CuMatrix{T} && size(P) == (m, m)
@test P * Wᴴ ≈ A
@test isisometric(Wᴴ; side = :right)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

Ac = similar(A)
P2, Wᴴ2 = @constinferred right_polar!(copy!(Ac, A), (P, Wᴴ), alg)
@test P2 === P
@test Wᴴ2 === Wᴴ
@test P * Wᴴ ≈ A
@test isisometric(Wᴴ; side = :right)
# work around extremely strict Julia criteria for Hermiticity
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P)) && isposdef(Hermitian(P))

noP = similar(P, (0, 0))
P2, Wᴴ2 = @constinferred right_polar!(copy!(Ac, A), (noP, Wᴴ), alg)
@test P2 === noP
@test Wᴴ2 === Wᴴ
@test isisometric(Wᴴ; side = :right)
P = A * Wᴴ' # compute P explicitly to verify W correctness
@test ishermitian(P; rtol = MatrixAlgebraKit.defaulttol(P))
@test isposdef(Hermitian(project_hermitian!(P)))
end
end
end
6 changes: 6 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ if CUDA.functional()
@safetestset "CUDA Hermitian Eigenvalue Decomposition" begin
include("cuda/eigh.jl")
end
@safetestset "CUDA Polar Decomposition" begin
include("cuda/polar.jl")
end
end

using AMDGPU
Expand All @@ -94,4 +97,7 @@ if AMDGPU.functional()
@safetestset "AMDGPU Hermitian Eigenvalue Decomposition" begin
include("amd/eigh.jl")
end
@safetestset "AMDGPU Polar Decomposition" begin
include("amd/polar.jl")
end
end