-
Notifications
You must be signed in to change notification settings - Fork 5
Add documentation for truncated decomposition keyword arguments #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for truncated decomposition keyword arguments #71
Conversation
…explanations Co-authored-by: lkdvos <37111893+lkdvos@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
@leburgel what do you think? |
|
@copilot can you also rewrite the Truncations section of the documentation page to include these functions, possibly with a fully worked out example? |
…ge guide Co-authored-by: lkdvos <37111893+lkdvos@users.noreply.github.com>
Done! I've completely rewritten the Truncations documentation page with comprehensive examples and usage guides. Changes in commit a6cec2d. The updated documentation now includes: New sections:
Example code covers:
All example code has been tested and verified to work correctly. The documentation builds successfully without errors. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot could you rework the examples into actual julia doctests? Note that for reproducibility it would be better to start from some hardcoded matrices instead of randomly generated ones.
…bility Co-authored-by: lkdvos <37111893+lkdvos@users.noreply.github.com>
Done in commit 6069be6. All examples have been converted to
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: Jutho <4162102+Jutho@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
17b3658 to
242f10d
Compare
|
After the build completes, the updated documentation will be available here |
leburgel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive imprrovement as far as I'm concerned, looks mostly good except for a few small comments.
src/interface/eig.jl
Outdated
| eig_trunc(A; trunc, kwargs...) -> D, V | ||
| eig_trunc(A, alg::AbstractAlgorithm) -> D, V | ||
| eig_trunc!(A, [DV]; kwargs...) -> D, V | ||
| eig_trunc!(A, [DV]; trunc, kwargs...) -> D, V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a default value that can be filled in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked this as optional [trunc], and the explanation below already lists the default value nothing.
|
Unrelated to this, but the text in the paragraph on Eigenvalue decompositions is a bit strange as it doesn't mention |
|
Ok I made some extra changes here but have finished. For me, this is good to go. |
* Bump v0.6 * rename `gaugefix` -> `fixgauge` * reduce unnecessary warnings * fix `copy_input` signatures in Mooncake tests * Add changelog to docs
eigh_truncto explaintrunckeyword and algorithm selectioneig_truncto explaintrunckeyword and algorithm selectionsvd_truncto explaintrunckeyword and algorithm selectionLatest Changes
Commit: Use svd_vals to verify truncation error equals discarded singular values
Improved the truncated SVD example to show that the reconstruction error equals the norm of the discarded singular values:
reconstruction_error < 2.1tonorm(B - U * S * Vh) ≈ norm(svd_vals(B)[3:end])All doctests pass and documentation builds successfully.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.