Skip to content

SafeSVD -1 allocation#186

Open
lkdvos wants to merge 5 commits intojh/safesvdaltfrom
ld-safesvd
Open

SafeSVD -1 allocation#186
lkdvos wants to merge 5 commits intojh/safesvdaltfrom
ld-safesvd

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Mar 13, 2026

@Jutho This might be a way to avoid the double allocation

@lkdvos lkdvos requested a review from Jutho March 13, 2026 13:08
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/yalapack.jl 0.00% 19 Missing ⚠️
src/implementations/svd.jl 0.00% 5 Missing ⚠️
Files with missing lines Coverage Δ
src/implementations/svd.jl 68.65% <0.00%> (-22.34%) ⬇️
src/yalapack.jl 0.00% <0.00%> (-60.95%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Member Author

lkdvos commented Mar 13, 2026

So after some playing around this was less minimal of a change than I was hoping for.
The annoying thing being that we really are assuming everything is going through f!(A, F, alg) in the end, which I now changed and therefore the chainrules also broke...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant