-
Notifications
You must be signed in to change notification settings - Fork 5
Use TestSuite for projections tests #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b17bbc to
33b61d4
Compare
33b61d4 to
e5b3073
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
| # test approximate error calculation | ||
| A = normalize!(A) | ||
| normA = norm(A) | ||
| A ./= normA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is normalize! another GPU problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to add support for it to GPUArrays.jl
What it says on the tin. Use
TestSuitefor the projections tests and additionally test them with some new element types!