Skip to content

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Dec 22, 2025

What it says on the tin. Use TestSuite for the projections tests and additionally test them with some new element types!

@kshyatt kshyatt requested review from Jutho and lkdvos December 22, 2025 18:23
@kshyatt kshyatt force-pushed the testsuite-projections branch from 4b17bbc to 33b61d4 Compare December 22, 2025 20:13
@kshyatt kshyatt force-pushed the testsuite-projections branch from 33b61d4 to e5b3073 Compare December 23, 2025 06:21
@kshyatt kshyatt enabled auto-merge (squash) December 23, 2025 06:55
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt kshyatt merged commit 4212b74 into main Dec 23, 2025
10 checks passed
@kshyatt kshyatt deleted the testsuite-projections branch December 23, 2025 07:49
# test approximate error calculation
A = normalize!(A)
normA = norm(A)
A ./= normA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is normalize! another GPU problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 😭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to add support for it to GPUArrays.jl

@lkdvos lkdvos mentioned this pull request Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants