Skip to content

Actually test GPU QR/LQ #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 2 commits into from
Dec 22, 2025
Merged

Actually test GPU QR/LQ #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae0d9a8
Actually test GPU QR/LQ
kshyatt Dec 22, 2025
a995946
Run only the LQ/QR testsuites on BK
kshyatt Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/lq.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
TestSuite.seed_rng!(123)
if T ∈ BLASFloats
if CUDA.functional()
CUDA_LQ_ALGS = LQViaTransposedQR.(CUSOLVER_HouseholderLQ(; positive = false), CUSOLVER_HouseholderLQ(; positive = true))
CUDA_LQ_ALGS = LQViaTransposedQR.((CUSOLVER_HouseholderQR(; positive = false), CUSOLVER_HouseholderQR(; positive = true)))
TestSuite.test_lq(CuMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
TestSuite.test_lq_algs(CuMatrix{T}, (m, n), CUDA_LQ_ALGS)
if n == m
Expand All @@ -27,9 +27,9 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
end
end
if AMDGPU.functional()
ROC_LQ_ALGS = LQViaTransposedQR.(ROCSOLVER_HouseholderLQ(; positive = false), ROCSOLVER_HouseholderLQ(; positive = true))
ROC_LQ_ALGS = LQViaTransposedQR.((ROCSOLVER_HouseholderQR(; positive = false), ROCSOLVER_HouseholderQR(; positive = true)))
TestSuite.test_lq(ROCMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
TestSuite.test_lq_algs(ROCMatrix{T}, (m, n), CUDA_LQ_ALGS)
TestSuite.test_lq_algs(ROCMatrix{T}, (m, n), ROC_LQ_ALGS)
if n == m
TestSuite.test_lq(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
TestSuite.test_lq_algs(Diagonal{T, ROCVector{T}}, m, (DiagonalAlgorithm(),))
Expand Down
11 changes: 6 additions & 5 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using SafeTestsets

is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
# don't run all tests on GPU, only the GPU
# specific ones
is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
if !is_buildkite
@safetestset "Algorithms" begin
include("algorithms.jl")
Expand All @@ -13,10 +13,6 @@ if !is_buildkite
@safetestset "Truncate" begin
include("truncate.jl")
end
@safetestset "QR / LQ Decomposition" begin
include("qr.jl")
include("lq.jl")
end
@safetestset "Singular Value Decomposition" begin
include("svd.jl")
end
Expand Down Expand Up @@ -71,6 +67,11 @@ if !is_buildkite
end
end

@safetestset "QR / LQ Decomposition" begin
include("qr.jl")
include("lq.jl")
end

using CUDA
if CUDA.functional()
@safetestset "CUDA Projections" begin
Expand Down