Test eigh_trunc_no_error with Mooncake #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Jutho
reviewed
Dec 16, 2025
| end | ||
|
|
||
| function copy_eigh_trunc_no_error(A, alg; kwargs...) | ||
| A = (A + A') / 2 |
Member
There was a problem hiding this comment.
should we use project_hermitian here?
Member
Author
There was a problem hiding this comment.
Don't we need #99 for that? Right now the AD frameworks are differentiating through this for free for us
Member
There was a problem hiding this comment.
Oh yes, I forgot that this was not yet implemented.
Jutho
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this in the previous PR