Pass compute_error and epsilon as arguments #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
This PR adds a `compute_error` field to `TruncatedAlgorithm` and changes `eig_trunc!`, `eigh_trunc!`, and `svd_trunc!` (and their non-mutating counterparts) to accept an array `epsilon` as part of their arguments. The purpose of this is twofold: to make handling the truncation error easier in AD, and to avoid forcing GPU synchronization.
kshyatt
force-pushed
the
ksh/error_arg
branch
from
771df3e to
cf31cb4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
Author
|
Discussed on slack and decided to close this in favor of #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
compute_errorfield toTruncatedAlgorithmand changeseig_trunc!,eigh_trunc!, andsvd_trunc!(and their non-mutating counterparts) to accept an arrayepsilonas part of their arguments. The purpose of this is twofold: to make handling the truncation error easier in AD, and to avoid forcing GPU synchronization.First run at addressing #114
Remaining TODOs:
compute_errorinalgalso in the Chainrules AD rules