Conversation
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
kshyatt
force-pushed
the
ksh/cu
branch
4 times, most recently
from
046f4d0 to
44d6fe6
Compare
kshyatt
force-pushed
the
ksh/cu
branch
2 times, most recently
from
11674d6 to
d4e1a03
Compare
|
Had to rebase on top of |
|
(just converted to draft to avoid rerunning all the tests for the various rebases) |
Oh good call, thank you! |
|
FWIW all this is why I normally don't cherry-pick off other branches 😇 |
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Since I stole the commits from here, I thought I'd might as well also go through and indicate some merge changes that were probably no longer needed, and meanwhile left some more comments
I know, since this is my bad I thought I would try and help fix it 😨 |
|
It might take me a few days to get back to all this as I have a few other things in flight |
kshyatt
force-pushed
the
ksh/cu
branch
2 times, most recently
from
de21294 to
0a2c75e
Compare
Fix sources Don't use a storagetype as input for MPS's Remove duplicates in extension more comments Apply suggestions from code review Co-authored-by: Lukas Devos <ldevos98@gmail.com> Fix sources Remove some extra storagetypes
|
OK, I think everything here got addressed, should I put this on R4R and run the full tests? |
2 participants
Mostly allowing passing an array type instead of just an element type to allow GPU arrays to back MPS tensors