Merged
Conversation
JohanMabille
requested changes
Jul 16, 2025
Member
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
The move assignment operator is missing.
src/utils/common.cpp
Outdated
|
|
||
| git_strarray_wrapper::~git_strarray_wrapper() | ||
| { | ||
| delete[] m_array.strings; |
Member
There was a problem hiding this comment.
The destructor should also reset the pointer to nullptr after its deletion, and set m_array.size to 0, so many calls to the destructor are harmless.
This could be moved in a private reset_str_array method that could be called from the destructor and other methods.
JohanMabille
approved these changes
Jul 16, 2025
Member
|
Thanks both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add git_strarray wrapper