Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented May 1, 2025

This PR adds support for RTL.

Update:

It looks like this will work but it requires a div over the text rather than all the code and figures.

@netlify
Copy link

netlify bot commented May 1, 2025

Deploy Preview for majestic-griffin-10b166 ready!

Name Link
🔨 Latest commit 7cb01d4
🔍 Latest deploy log https://app.netlify.com/sites/majestic-griffin-10b166/deploys/6812f18cbf444400089f11ef
😎 Deploy Preview https://deploy-preview-4--majestic-griffin-10b166.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented May 1, 2025

@github-actions github-actions bot temporarily deployed to pull request May 1, 2025 03:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 1, 2025 04:04 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 1, 2025

@Zahra-khanzadeh I did some experimenting using right justified text via html tags and it works, but I think we can improve this through the theme, which is something I can work on.

Also when you open a PR it will now automatically build a preview that you can see by clicking on the View deployment button.

Heres is the link to this PR's preview

https://6812f2b7a88f2708bc5f61f0--majestic-griffin-10b166.netlify.app/about_py

@Zahra-khanzadeh
Copy link
Contributor

Thank you so much @mmcky — this is fantastic news!
The RTL preview looks great, and I really appreciate all the work you've done to support it.

I also wanted to mention one more quick point about technical terms: in Persian academic and tech settings, we often use words like Python and company/library names as-is. So I’ve kept them untranslated in the current version. They seem to display fine now, but if any styling or formatting needs adjustment later, I’d be happy to help however I can.

Thanks again — it’s really exciting to see everything coming together like this!

@mmcky
Copy link
Contributor Author

mmcky commented Aug 12, 2025

We will not use this approach so I am closing this issue.

This is being added to the theme QuantEcon/quantecon-book-theme#292

@mmcky mmcky closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants