Cherrelle-Morrison-Assignment-submission#25
Open
CherrelleMorrison wants to merge 1 commit intoQualityWorksCG:mainfrom
Open
Cherrelle-Morrison-Assignment-submission#25CherrelleMorrison wants to merge 1 commit intoQualityWorksCG:mainfrom
CherrelleMorrison wants to merge 1 commit intoQualityWorksCG:mainfrom
Conversation
dimitriharding
requested changes
Oct 31, 2022
Contributor
dimitriharding
left a comment
dimitriharding
left a comment
There was a problem hiding this comment.
Please see review changes.
| const array = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; | ||
|
|
||
| function printElement(item){ | ||
| console.log("The current element is "+item) |
Contributor
There was a problem hiding this comment.
You are going to be mad at yourself, but the instructions wanted you to use the template literal syntax instead of quotes.
Suggested change
| console.log("The current element is "+item) | |
| console.log(`The current element is ${item}`) |
| // and print "Geology paper marked" | ||
| return new Promise((resolve,reject) => { | ||
| setTimeout(() => { | ||
| console.log("Geology paper marked"); |
Contributor
There was a problem hiding this comment.
Ideally, we would have wanted to resolve the text from the promise rather than printing it in the promise, but no marks will be deducted since the instructions could have been misinterpreted.
| class Vehicle{ | ||
| constructor(wheels, bodyType){ | ||
| this.wheels = wheels; | ||
| this.bodyType = bodyType; |
Contributor
There was a problem hiding this comment.
Since classes are used to reduce code, you were expected to define the whatIsMyName method on the "Vehicle" class. So that way you wouldn't have to add it to all of the child classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.