Use mul_add with a float inversion instead of mul_neg_add #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is more readable that way and also more portable to other SIMD libraries; wide is the only one with mul_neg_add. After my Lokathor/wide#242 this generates identical assembly to mul_neg_add
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 99.82% 99.82% -0.01%
==========================================
Files 13 13
Lines 2261 2258 -3
==========================================
- Hits 2257 2254 -3
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is more readable that way and also more portable to other SIMD libraries; wide is the only one with mul_neg_add. After my Lokathor/wide#242 this generates identical assembly to mul_neg_add on AVX2, AVX-512 and NEON
Prerequisite for porting to fearless_simd since my PR for mul_neg_add got rejected: linebender/fearless_simd#162