Skip to content

feat(eksanywhere): add cloud credential for eks anywhere (#2578)#2581

Closed
pggb25 wants to merge 2 commits intonew-navigationfrom
feat/new-navigation-cherry-pick-staging
Closed

feat(eksanywhere): add cloud credential for eks anywhere (#2578)#2581
pggb25 wants to merge 2 commits intonew-navigationfrom
feat/new-navigation-cherry-pick-staging

Conversation

@pggb25
Copy link
Copy Markdown
Collaborator

@pggb25 pggb25 commented Apr 7, 2026

Summary

report of commit

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@pggb25 pggb25 added the V5 label Apr 7, 2026
@pggb25 pggb25 force-pushed the feat/new-navigation-cherry-pick-staging branch from a98b3e0 to 6288589 Compare April 7, 2026 16:26
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 44.66019% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.69%. Comparing base (933c1b9) to head (49f0c63).
⚠️ Report is 6 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...er-credentials-modal/cluster-credentials-modal.tsx 45.00% 32 Missing and 12 partials ⚠️
...s-cloud-credentials/settings-cloud-credentials.tsx 47.61% 6 Missing and 5 partials ⚠️
libs/shared/ui/src/lib/components/icon/icon.tsx 0.00% 1 Missing ⚠️
.../ui/src/lib/components/icon/icons/eks-anywhere.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2581      +/-   ##
==================================================
+ Coverage           45.18%   45.69%   +0.51%     
==================================================
  Files                1112     1123      +11     
  Lines               22556    22749     +193     
  Branches             6587     6649      +62     
==================================================
+ Hits                10192    10396     +204     
+ Misses              10524    10453      -71     
- Partials             1840     1900      +60     
Flag Coverage Δ
unittests 45.69% <44.66%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pggb25 pggb25 closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant