Skip to content

feat(v5): add last deployment time to "last deployment" cell of services list#2576

Merged
rmnbrd merged 3 commits intonew-navigationfrom
feat/new-nav/add-deployment-date-to-services-list
Apr 8, 2026
Merged

feat(v5): add last deployment time to "last deployment" cell of services list#2576
rmnbrd merged 3 commits intonew-navigationfrom
feat/new-nav/add-deployment-date-to-services-list

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 3, 2026

Summary

PR adding last deployment time to the "last deployment" cell of services list.

Screenshots / Recordings

Screenshot 2026-04-03 at 17 25 33

@rmnbrd rmnbrd self-assigned this Apr 3, 2026
@rmnbrd rmnbrd added the V5 label Apr 3, 2026
@rmnbrd rmnbrd requested a review from RemiBonnet April 8, 2026 08:16
@rmnbrd rmnbrd marked this pull request as ready for review April 8, 2026 08:16
Copilot AI review requested due to automatic review settings April 8, 2026 08:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a relative “last deployed” timestamp alongside the deployment action label in the Services list “Last deployment” column.

Changes:

  • Display relative last deployment time (via timeAgo) next to the deployment action in the services list cell.
  • Adjust hover/underline behavior by moving underline styling from the Link to inner elements via group-hover:*.
  • Update ServiceList snapshots to reflect the new DOM structure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
libs/domains/services/feature/src/lib/service-list/service-list-cells/service-last-deployment-cell.tsx Adds relative timestamp display and adjusts link/hover styling in the “Last deployment” cell.
libs/domains/services/feature/src/lib/service-list/snapshots/service-list.spec.tsx.snap Updates snapshots for the changed markup/styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@8b0ddd8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ervice-list-cells/service-last-deployment-cell.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2576   +/-   ##
=================================================
  Coverage                  ?   45.93%           
=================================================
  Files                     ?      621           
  Lines                     ?    14629           
  Branches                  ?     4300           
=================================================
  Hits                      ?     6720           
  Misses                    ?     6704           
  Partials                  ?     1205           
Flag Coverage Δ
unittests 45.93% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we improve the width of the cell for small screen?

Image

@rmnbrd rmnbrd merged commit c5aabf6 into new-navigation Apr 8, 2026
10 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/add-deployment-date-to-services-list branch April 8, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants