Skip to content

feat(QOV-794): add cronjob nodepool UI to console#2553

Merged
RemiBonnet merged 2 commits intostagingfrom
feat/dedicated-cronjob-nodepool
Apr 9, 2026
Merged

feat(QOV-794): add cronjob nodepool UI to console#2553
RemiBonnet merged 2 commits intostagingfrom
feat/dedicated-cronjob-nodepool

Conversation

@Guimove
Copy link
Copy Markdown
Contributor

@Guimove Guimove commented Mar 27, 2026

Summary

  • Add cronjob nodepool type to NodepoolModal (type, prefix, form handling)
  • Add cronjob nodepool card to NodepoolsResourcesSettings with consolidation/limits display
  • Add cronjob nodepool enable toggle in ClusterResourcesSettings
  • Uses as any casts with TODO comments pending TypeScript client regeneration

Depends on: OpenAPI spec PR (for TS client regeneration)

Test plan

  • Regenerate qovery-typescript-axios from updated OpenAPI spec
  • Remove as any casts and replace with proper types
  • Enable cronjob nodepool toggle, verify modal opens and saves
  • Verify consolidation schedule and resource limits display correctly
  • Verify disabling toggle clears the override
  • Verify GPU and stable nodepools still work correctly

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview d8a1b661-72ac-4c66-97c9-89bc61392356 test-prod-clone-prod
/qovery preview 8ba67a97-56f5-4655-9090-f29ba94c581f test-prod-clone
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Make it work, make it right, make it fast

@Guimove Guimove marked this pull request as draft March 27, 2026 17:04
@Guimove Guimove force-pushed the feat/dedicated-cronjob-nodepool branch from 5e8ad24 to 032d48a Compare March 27, 2026 20:27
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.67%. Comparing base (bca7920) to head (81ff5db).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...sources-settings/nodepool-modal/nodepool-modal.tsx 7.14% 13 Missing ⚠️
...esources-settings/nodepools-resources-settings.tsx 20.00% 8 Missing ⚠️
...-resources-settings/cluster-resources-settings.tsx 25.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2553      +/-   ##
===========================================
- Coverage    47.72%   47.67%   -0.05%     
===========================================
  Files         1281     1281              
  Lines        23826    23858      +32     
  Branches      7037     7053      +16     
===========================================
+ Hits         11370    11374       +4     
- Misses       10297    10324      +27     
- Partials      2159     2160       +1     
Flag Coverage Δ
unittests 47.67% <15.62%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Guimove Guimove force-pushed the feat/dedicated-cronjob-nodepool branch 2 times, most recently from 3c317bf to 5ffae68 Compare March 30, 2026 08:23
@Guimove Guimove changed the title feat: add cronjob nodepool UI to console feat(QOV-794): add cronjob nodepool UI to console Mar 30, 2026
@Guimove Guimove marked this pull request as ready for review March 30, 2026 16:05
@Guimove Guimove force-pushed the feat/dedicated-cronjob-nodepool branch from 1549ac3 to 4bad18b Compare April 9, 2026 07:15
@Guimove Guimove force-pushed the feat/dedicated-cronjob-nodepool branch from 4bad18b to 1a247dd Compare April 9, 2026 07:16
@RemiBonnet RemiBonnet self-requested a review April 9, 2026 07:29
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Guimove lgtm 👍

I just added a cosmetic improvement

@RemiBonnet RemiBonnet merged commit 9aaab7e into staging Apr 9, 2026
25 of 27 checks passed
@RemiBonnet RemiBonnet deleted the feat/dedicated-cronjob-nodepool branch April 9, 2026 07:45
@RemiBonnet
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.300.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants