Skip to content

[WIP] Sliced OT Plans#767

Open
eloitanguy wants to merge 65 commits into
PythonOT:masterfrom
eloitanguy:dev_sliced_plans
Open

[WIP] Sliced OT Plans#767
eloitanguy wants to merge 65 commits into
PythonOT:masterfrom
eloitanguy:dev_sliced_plans

Conversation

@eloitanguy
Copy link
Copy Markdown
Collaborator

@eloitanguy eloitanguy commented Oct 7, 2025

Types of changes

Note: this PR continues #757 which was merged by accident.

Implements min-Pivot Sliced Plans Mahey et al., Tanguy et al. and Expected Sliced Plans Liu et al., Tanguy et al., and Generalised Sliced Wasserstein Plans Chapel et al..

Checklist:

  • update PR number in RELEASES.md and README.md
  • implement min-Pivot Sliced
  • implement Expected Sliced: todo: raise error when using tf or jax, test accordingly, and add a warning in the doc
  • example
  • testing (min-Pivot Sliced and Expected Sliced)
  • discuss API choices
  • Generalised SW plans implementation + example
  • doc proofreading (min-Pivot Sliced and Expected Sliced)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 80.32258% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.51%. Comparing base (6e21613) to head (43dd522).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
- Coverage   96.78%   96.51%   -0.28%     
==========================================
  Files         118      121       +3     
  Lines       23721    23391     -330     
==========================================
- Hits        22958    22575     -383     
- Misses        763      816      +53     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@clbonet clbonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR @eloitanguy @lchapel!
Here are few comments.

Comment thread ot/lp/solver_1d.py Outdated
Comment thread ot/lp/solver_1d.py Outdated
Comment thread ot/sliced/_sliced_distances.py Outdated
Comment thread ot/sliced/_sliced_distances.py Outdated
Comment thread ot/sliced/_sliced_plans.py Outdated
Comment thread ot/sliced/_sliced_plans.py
Comment thread ot/sliced/_sliced_plans.py
Comment thread ot/sliced/_sliced_plans.py
Comment thread ot/utils.py
Comment thread test/test_sliced.py Outdated
@rflamary rflamary requested a review from clbonet May 29, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants