Draft
Conversation
…traint management
mrmundt
reviewed
Jan 23, 2026
Comment on lines
-52
to
-53
| CONFIG = KnitroConfig() | ||
| config: KnitroConfig |
Contributor
There was a problem hiding this comment.
Is there a reason that you are taking this out of base? It seems like it makes more sense here.
Contributor
Author
There was a problem hiding this comment.
I moved it because the config of the persistent interface needs to inherit from the PersistentSolverConfig and the direct interface needs to not inherit from that class. So I moved the typehint to each implementation.
Member
|
Overall, this looks good. My biggest question is why do so many solver tests need to be skipped for the persistent interface? Some of them look like they are testing pretty fundamental functionality, |
Contributor
Author
|
@jsiirola Totally agree with you. I’ll rework this PR and remove those skips. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NA
Summary/Motivation
This PR adds a persistent solver implementation for KNITRO.
Changes proposed in this PR
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: