Update Ipopt interface in contrib.solver#3792
Merged
blnicho merged 51 commits intoPyomo:mainfrom Feb 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3792 +/- ##
==========================================
- Coverage 89.48% 88.73% -0.75%
==========================================
Files 904 910 +6
Lines 105385 107811 +2426
==========================================
+ Hits 94299 95671 +1372
- Misses 11086 12140 +1054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blnicho
approved these changes
Feb 11, 2026
| v_id = id(v) | ||
| rc[v_id] = (v, 0) | ||
| if self._nl_info.eliminated_vars: | ||
| raise MouseTrap( |
Contributor
There was a problem hiding this comment.
Why is this a mouse trap? I'm not sure I understand when MouseTrap should be expected?
Contributor
There was a problem hiding this comment.
Oh, I see! It's in the doc string for MouseTrap!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3807 .
Summary/Motivation:
This started as an update the to SOL file parser to resolve some holes in the parse logic around parsing AMPL options, and turned into a significant rework of the Ipopt solver interface.
Changes proposed in this PR:
delete=option to the TempfileManager contexts so that we can create "unmanaged" temporary files through the context.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: