fix: 🧑💻 Add kwargs explicitly for app-command decorators#3119
Open
ToothyDev wants to merge 4 commits intoPycord-Development:masterfrom
Open
fix: 🧑💻 Add kwargs explicitly for app-command decorators#3119ToothyDev wants to merge 4 commits intoPycord-Development:masterfrom
ToothyDev wants to merge 4 commits intoPycord-Development:masterfrom
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3119/head:pr-3119
git checkout pr-3119This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3119/head |
ToothyDev
requested review from
EmmmaTech,
JustaSqu1d,
Lulalaby and
plun1331
Paillat-dev
previously approved these changes
Feb 28, 2026
Member
Paillat-dev
left a comment
Paillat-dev
left a comment
There was a problem hiding this comment.
Should do the trick for now
Paillat-dev
approved these changes
Feb 28, 2026
Member
Paillat-dev
left a comment
Paillat-dev
left a comment
There was a problem hiding this comment.
Should do the trick for now
Lulalaby
requested changes
Mar 2, 2026
Comment on lines
+43
to
+45
| - Fixed the `slash_command`, `message_command` and `user_command` decorators to | ||
| explicitly list the accepted parameters, and have a return type. | ||
| ([#3119](https://github.com/Pycord-Development/pycord/pull/3119)) |
Member
There was a problem hiding this comment.
I do not like the changelog entry. It's not descriptive enough about what it fixes. Just "how".
Contributor
Author
There was a problem hiding this comment.
Well, it fixes them not being listed and having a return type. I copied this from an existing changelog entry so idk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This explicitly adds typed kwargs to the
slash_command,user_commandandmessage_commanddecorators as well as to the basicapplication_commanddecorator.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.