refactor(voice): Rewrite Voice Internals & DAVE Support#2873
Draft
DA-344 wants to merge 74 commits intoPycord-Development:masterfrom
Draft
refactor(voice): Rewrite Voice Internals & DAVE Support#2873DA-344 wants to merge 74 commits intoPycord-Development:masterfrom
DA-344 wants to merge 74 commits intoPycord-Development:masterfrom
Conversation
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
…344/pycord into feat/voice-rewrite-and-fixes
3 tasks
Contributor
Author
|
once i manage to fix tests this pr will be ready for review. |
Member
|
Nice, thank you a lot for the work ! |
Member
|
@DA-344 The fix for the tests is quite easy, just edit the [tool.tox.env_run_base]
description = "run unit tests"
commands = [["pytest", { replace = "posargs", default = ["tests"], extend = true }]]
dependency_groups = ["test"]
extras = ["voice"]Should be enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites voice internals to have a cleaner, easier-to-maintain, voice implementation.
Adds support for DAVE connections.
Voice receive is currently broken
-> This code is partially inspired on discord.py's current voice implementation
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.Related
Fixes #2833