pub(crate) all functions prefixed with _Py#6053
Merged
Merged
Conversation
ngoldbaum
reviewed
May 18, 2026
Icxolu
reviewed
May 19, 2026
Member
|
Sorry for not mentioning this last time. What is the motivation for making them private rather than removing them? I don't see any uses of these function within |
Contributor
Author
|
All of these functions are mentioned within https://github.com/PyO3/pyo3/blob/main/pyo3-ffi/src/impl_/macros.rs#L26-L222; do you think removing them won't cause breakage? |
Member
|
That is a work around for linking symbols that start with |
Icxolu
reviewed
May 23, 2026
Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
Icxolu
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.