add PyObject_HasAttrWithError & use it in PyAnyMethods::hasattr#5944
Open
bschoenmaeckers wants to merge 3 commits intoPyO3:mainfrom
Open
add PyObject_HasAttrWithError & use it in PyAnyMethods::hasattr#5944bschoenmaeckers wants to merge 3 commits intoPyO3:mainfrom
PyObject_HasAttrWithError & use it in PyAnyMethods::hasattr#5944bschoenmaeckers wants to merge 3 commits intoPyO3:mainfrom
Conversation
bschoenmaeckers
force-pushed
the
hasattr
branch
3 times, most recently
from
b7788e9 to
03bea8a
Compare
bschoenmaeckers
force-pushed
the
hasattr
branch
2 times, most recently
from
0e7f4b4 to
90c7d67
Compare
davidhewitt
reviewed
Apr 11, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, a few suggestions to this one.
| let result = unsafe { | ||
| ffi::compat::PyObject_HasAttrWithError( | ||
| self.as_ptr(), | ||
| attr_name.into_pyobject(py).map_err(Into::into)?.as_ptr(), |
Member
There was a problem hiding this comment.
We have generally tried to avoid the .as_ptr() on temporaries like this because the innocent-looking refactoring out to a variable creates a dangling ptr.
I think also it's worth having the fn inner pattern, see e.g. getattr, can pass any: &Bound<'py, PyAny>, attr_name: Borrowed<'_, '_, PyString>,, which can slightly reduce generic code bloat by having the error handling portion only compiled once.
Comment on lines
+1032
to
+1033
| let bound = unsafe { Bound::from_owned_ptr(py, resp_ptr) }; | ||
| Ok(Some(bound)) |
Member
There was a problem hiding this comment.
Suggested change
| let bound = unsafe { Bound::from_owned_ptr(py, resp_ptr) }; | |
| Ok(Some(bound)) | |
| Ok(Some(unsafe { resp_ptr.assume_owned_unchecked(py) })) |
| where | ||
| N: IntoPyObject<'py, Target = PyString>, | ||
| { | ||
| fn inner<'py>( |
Member
There was a problem hiding this comment.
I think it would be desirable to restore the fn inner pattern here too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5940