introduce fast path to LazyTypeObject::get_or_init#5324
Merged
davidhewitt merged 7 commits intoPyO3:mainfrom Aug 17, 2025
Merged
introduce fast path to LazyTypeObject::get_or_init#5324davidhewitt merged 7 commits intoPyO3:mainfrom
LazyTypeObject::get_or_init#5324davidhewitt merged 7 commits intoPyO3:mainfrom
Conversation
Merged
CodSpeed Performance ReportMerging #5324 will degrade performances by 12.85%Comparing Summary
Benchmarks breakdown
|
Icxolu
reviewed
Aug 15, 2025
Icxolu
approved these changes
Aug 15, 2025
Member
Author
|
Seems flaky on downloads, will keep retrying 🤔 |
Member
|
Looks like we're not the only ones hitting this currently: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Channel.20manifest.20downloads.20timeout.20in.20GHA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #5223, because this part of the refactor is worth pulling out and highlighting as a perf improvement (I think).