-
Notifications
You must be signed in to change notification settings - Fork 151
Encapsulate pipette batch scheduling into backend-agnostic module #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rickwierenga
merged 60 commits into
PyLabRobot:main
from
BioCam:encapsulate-pipette-batch-scheduling
Apr 24, 2026
Merged
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
d8babe3
Encapsulate pipette batch scheduling into dedicated module
BioCam 8eece6f
make x_grouping_tolerance required argument
BioCam cbee224
Merge branch 'PyLabRobot:main' into encapsulate-pipette-batch-scheduling
BioCam fa39d12
Merge branch 'PyLabRobot:main' into encapsulate-pipette-batch-scheduling
BioCam a032cd5
Fix spacings list sizing in plan_batches when num_channels exceeds ma…
BioCam 4310973
Remove detection parameter exposure from probe_liquid_heights (defer …
BioCam 607565b
explain dual exception handling
BioCam ae9cc13
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam b3b326b
Merge branch 'PyLabRobot:main' into encapsulate-pipette-batch-scheduling
BioCam 6d53765
Refactor plan_batches to accept containers, add execute_batched, fix …
BioCam 564f36a
create `print_batches`
BioCam f6e8690
fix linting
BioCam 9c3448a
`make format`
BioCam 8c3b851
Merge branch 'main' into encapsulate-pipette-batch-scheduling
rickwierenga 5bf7bb6
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam 5147f11
update docstrings
BioCam 5e46375
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam d143bdf
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam c7e18ff
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam 1f94198
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam 19f7332
Merge origin/main into encapsulate-pipette-batch-scheduling
BioCam 3be2bc8
Improve probe_liquid_heights Z handling, use compute_channel_offsets …
BioCam 8ad38ab
add TODO for move to radii model (out of PR scope)
BioCam cee71a1
Allow duplicate `use_channels`, remove redundant inline comment
BioCam afe8996
Address PR review: reorder `validate_channel_selections` args, use li…
BioCam 37e5449
Return data from callbacks, don't mutate inputs, use literal box-draw…
BioCam b485855
Simplify plan_batches to coordinates-only, validate channel_spacings,…
BioCam 6f8f734
Remove obsolete odd-span center shift, inline `_offsets_for_consecuti…
BioCam cd192fc
Route single-channel container offsets through compute_channel_offset…
BioCam 6dcf72e
Apply container offsets for single-channel targets, consolidate lld_m…
BioCam f6cd56f
Guard _min_spacing_between against non-adjacent channel indices
rickwierenga 20ad929
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam a19c32d
Scope `_effective_spacing` to sub-group in `compute_single_container_…
BioCam b206201
Inline `_min_spacing_between` into `_span_required`
BioCam 7307c8e
Remove redundant lo→candidate span check from batch partitioning
BioCam 665fc36
Move `compute_single_container_offsets` to channel_positioning
BioCam b3e43e9
Rename to `compute_nonconsecutive_channel_offsets`, improve docstring…
BioCam c488da2
Simplify batch partitioning, inline into plan_batches, update stale d…
BioCam 1d100ff
Reject duplicate channels in `probe_liquid_heights` but allow in gene…
BioCam 16a323f
Override `execute_batched` in chatterbox, restructure `probe_liquid_h…
BioCam f47c312
Extract `_prepare_batched` for reuse by future aspirate/dispense
BioCam 3be0993
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam 25276b8
Promote per-batch LLD callback to override hook, collapse chatterbox
BioCam 54daf5c
Accept per-container `LLDMode` list in `probe_liquid_heights`
BioCam b79b41a
`make format`
BioCam 967a0f8
Merge remote-tracking branch 'origin/main' into encapsulate-pipette-b…
rickwierenga 553bae0
Merge branch 'encapsulate-pipette-batch-scheduling' of https://github…
rickwierenga aa8bdfa
Replace greedy first-fit batching with container-aware exact-cover pl…
rickwierenga 5259557
Rewrite pipette_batch_scheduling module docstring with problem classi…
BioCam 57e47dc
Narrow `is_valid_batch` return in tests and drop unused imports
BioCam bb743ca
Merge pull request #1 from PyLabRobot/refactor-plan-batches-exact-cover
BioCam a5eb57d
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam d939f3f
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam 6fcb20a
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam dbc6d95
Review fixes: log_batches, deprecate move_to_z_safety_after, restore …
rickwierenga a465d04
Merge branch 'main' into encapsulate-pipette-batch-scheduling
rickwierenga 58d473d
Review fixes: canonical x_position, support duplicate channels, depre…
rickwierenga 4697a88
Merge branch 'main' into encapsulate-pipette-batch-scheduling
rickwierenga d6048a4
Remove duplicate TestChannelsMinimumYSpacing class in STAR_tests
rickwierenga 0f7a583
Apply ruff format and import sort
rickwierenga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
616 changes: 316 additions & 300 deletions
616
pylabrobot/liquid_handling/backends/hamilton/STAR_backend.py
Large diffs are not rendered by default.
Oops, something went wrong.
|
BioCam marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.