Fix #856 by ignoring combining diacritics when computing line length#869
Open
reynoldsnlp wants to merge 3 commits intoPyCQA:mainfrom
Open
Fix #856 by ignoring combining diacritics when computing line length#869reynoldsnlp wants to merge 3 commits intoPyCQA:mainfrom
reynoldsnlp wants to merge 3 commits intoPyCQA:mainfrom
Conversation
Member
|
Can you write a test demonstrating this change (and so it doesn't regress) -- thanks for your contribution! 🎉 |
reynoldsnlp
changed the title
Author
|
@asottile I'm not sure I wrote that test correctly, so make sure you think it looks good. |
Author
|
Thanks for your help! I'll be very happy to have that fixed. |
Author
|
Do the checks need to be restarted? |
Member
|
Can you rebase? I expect the checks will run correctly then if you rebase and force-push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also alphabetized the import statements by moving
bisectto the top.