Open
Conversation
…losing`` flag.
Member
|
I'm not quite sure I like this approach but I'm also not sure there's a better approach. :( |
testsuite/support.py
Outdated
| (mutates pep8style) | ||
|
|
||
| Usage in test: | ||
| #: #E133:3:1 --with-hanging |
Member
There was a problem hiding this comment.
This is wrong, the usage in test would be:
#: E133:3:1 --with-hanging
Author
There was a problem hiding this comment.
Reading it over, I got the command line arg wrong too, I'll update this, should be --hang-closing not --with-hanging
Author
|
I'm open to other approaches, my other thought was to have another test file, e.g. Let me know if you'd like me to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test for
E133which is enabled by the optional flag--hang-closingfor issues #293Per the docs:
Specifically this throws an
E133error forand is Okay for