Open
Conversation
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
…rom rb to r and write more from wb to w Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
…ning tests Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
reingart
requested changes
Nov 5, 2023
Member
reingart
left a comment
reingart
left a comment
There was a problem hiding this comment.
This PR seems like a nice initial attempt for coverage of this file formats unit tests.
It would be great to have more real tests for TXT and DBF file formats, specially with a real invoice fields and values.
Most of the UT here are pretty simple, and sample files entrada.txt and facturas.json don't seems to be used.
A similar sample file for DBF would be great.
And you should check field and formats like in the CSV file format unit tests.
If you want we can merge this PR and create the more extensive UT in a new PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to close issue #90. The PR contains unit tests for the following files in formatos module
Checklist
Manual test evidence
(attach command-line examples, execution output & logs, etc.)