Fix scroll position loss on expanded/collapsed mode switch#134
Open
Fix scroll position loss on expanded/collapsed mode switch#134
Conversation
- Save scroll positions before mode switch and restore them after - Add saveScrollPositions/restoreScrollPositions JS functions - Replace _needsScrollToBottom with _needsScrollRestore for mode switches - Fix WsBridgeServer SemaphoreSlim race condition in Broadcast() - Handle ObjectDisposedException when semaphore disposed during async send - Add unit tests for SemaphoreSlim concurrency patterns - Add UI scenario test for scroll position preservation Fixes: scroll position resets when switching between expanded and grid view Fixes: unobserved exception 'Cannot access disposed SemaphoreSlim' in crash log Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two bugs:
Bug 1: Scroll position resets when switching modes
When switching between expanded (single session view) and collapsed (grid view) modes, the scroll position would reset to bottom instead of being preserved.
Root cause: Both \ExpandSession()\ and \CollapseExpanded()\ unconditionally set _needsScrollToBottom = true, which forced all .messages\ containers to scroll to bottom.
Fix:
estoreScrollPositions\ JavaScript functions
Bug 2: SemaphoreSlim disposed exception (crash log)
\
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Threading.SemaphoreSlim'.
at System.Threading.SemaphoreSlim.Release()
at WsBridgeServer.Broadcast()
\\
Root cause: In \Broadcast(), there was a race condition where the semaphore \sendLock\ could be disposed by a concurrent cleanup while \Task.Run\ was still using it.
Fix: Added try-catch blocks around \WaitAsync()\ and \Release()\ calls to gracefully handle \ObjectDisposedException.
Changes
Testing
et10.0-windows10.0.19041.0)