Fix build.sh to use Homebrew Clang on mac#527
Open
PLAZMAMA wants to merge 5 commits intoPufferAI:4.0from
Open
Conversation
PLAZMAMA
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue
Commit ab75881 addresses the -lomp5 compilation error on mac, however this doesn't fix the root cause.
Root Cause
The root cause is that mac's non-standard clang(Apple Clang) links differently than normal clang. For example, the
-fopenmpflag isn't supported in apple clang so it creates a compilation error even after the "-lomp5 fix".This means that this issue will happen with other libs in the future and will have to be fixed and maintained constantly.
The Fix
This PR addresses the original issue and root cause by forcing the user to use "real" clang in a clear way which makes compilation identical on Linux and Mac.
Additional Notes
brew install llvm. So this shouldn't make mac user's life that much harder.Working Build Commands on Mac
./build.sh breakout --local./build.sh breakout --cpu