Fix memory leak of StaticOMPArg array in vecenv#521
Open
Bortlesboat wants to merge 1 commit intoPufferAI:4.0from
Open
Fix memory leak of StaticOMPArg array in vecenv#521Bortlesboat wants to merge 1 commit intoPufferAI:4.0from
Bortlesboat wants to merge 1 commit intoPufferAI:4.0from
Conversation
The StaticOMPArg array allocated in create_static_threads was assigned to a local pointer that went out of scope, leaking (buffers * sizeof(StaticOMPArg)) bytes per thread pool creation. Store the pointer in StaticThreading so static_vec_close can free it after joining all threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StaticOMPArgarray allocated increate_static_threads()is assigned to a local pointer that goes out of scope when the function returns. Sincestatic_vec_close()has no reference to it, the array is never freed — leakingbuffers * sizeof(StaticOMPArg)bytes per thread pool creation.This stores the pointer in
StaticThreadingsostatic_vec_closecan free it after joining all threads.Changes:
StaticOMPArgsoStaticThreadingcan hold a pointer to itthread_argsfield toStaticThreadingvec->threading->thread_argsstatic_vec_closealongside the other threading allocationsSafe because by the time
static_vec_closeruns, the shutdown flag is set and all threads have been joined — no thread is still referencing the args.