Revert "Filter out [ct:xxx] tags to prevent PE client crashes"

[ACaiCat]

Reverts #3193

Terraria PE v1.4.5.6 totally resolves the CT tag crash bug

[greptile-apps]

Greptile Summary

This PR reverts #3193 by removing the [ct:xxx] chat tag filter and the associated AllowCtTag configuration option, based on the claim that Terraria PE v1.4.5.6 resolves the crash bug that originally motivated the filter. The code changes are clean — the regex, the config field, and the now-unused using System.Text.RegularExpressions import are all consistently removed.

Confidence Score: 5/5

Safe to merge assuming the target Terraria server version requires PE clients to be on v1.4.5.6 or later.

The revert is mechanically clean — the regex, config field, and unused import are all removed consistently with no dangling references. The only non-blocking consideration is whether older PE clients (pre-1.4.5.6) can still connect and be crashed by [ct:xxx] tags, but that is a deployment/versioning question rather than a code defect.

No files require special attention.

Important Files Changed

Filename	Overview
TShockAPI/TShock.cs	Removes the [ct:xxx] regex filter from OnChat and the now-unused System.Text.RegularExpressions import; no remaining Regex usages in the file.
TShockAPI/Configuration/TShockConfig.cs	Removes the AllowCtTag config field; no remaining references to it exist anywhere in the codebase.

Sequence Diagram

sequenceDiagram
    participant PC as Terraria Client (PC/PE)
    participant TS as TShock OnChat Handler
    participant Srv as Server/Other Players

    PC->>TS: Send chat message (may contain [ct:xxx] tags)
    Note over TS: Truncate if necessary
    TS->>Srv: Forward chat text as-is
    Srv-->>PC: Broadcast to all players

    Note over PC: PE v1.4.5.6+ handles [ct:xxx] tags without crashing

Loading

_{Reviews (1): Last reviewed commit: "Revert "Filter out [ct:xxx] tags to prev..." | Re-trigger Greptile}

[lost-werewolf]

Mobile v1.4.5.6 patches all invalid ControlsTouch tags from my testing. Hopefully for good this time.