Fix/build warnings 2024 09 15#159

Open

brmassa wants to merge 31 commits intoProwlEngine:developmentfrom

brmassa:fix/build-warnings-2024-09-15

Commits on Sep 18, 2024

refactor: comment out private fields/variables that are not used
brmassa
committed
refactor: comment out private fields that are not used
brmassa
committed
fix: check of not null
brmassa
committed
fix: replace `async Task` for `void` for a method that do not use any async internally
brmassa
committed
fix: switch for a SceneViewPreferences.Instance.GridType must contain all possibilities
brmassa
committed
fix: public static int OrderlessHash<T> must ensure that T is not null because it will be the index of a dictionary
brmassa
committed
refactor: optimizing Prowl.Runtime.GUI.Spacing to reuse code
brmassa
committed
fix: assure that the t.Get is not null inside SerializedProperty.Merge
brmassa
committed
fix: KeyFrame's CompareTo and Equals methods allowing null (it will be dealt internally)
brmassa
committed
fix: comment unused field and SceneMeshData.MeshData, that are never used
brmassa
committed
fix: new InspectorWindow.CreateInstanceCustomEditor to optimized and enhance code
brmassa
committed
fix: EngineObject.FindObjectsOfType should never return null
brmassa
committed
fix: some arguments passed using `ref`instead the `in` used in the signature
brmassa
committed
fix: use `await` to wait async method to finish
brmassa
committed
fix: rename Prowl.Editor.SelectHandler's Equals to EqualsFunc to avoid name conflict
brmassa
committed
fix: using new and override to avoid conflict with inherited methods
brmassa
committed
fix: unreachable code in Prowl.Runtime.PhysicsSetting
brmassa
committed
fix: variable is assigned but its value is never used
brmassa
committed
fix: check null before using it
brmassa
committed
refactor: in `AssetsBrowserWindow.DrawFileEntry` no need to use hasSubset. just check if `subAsset` is not null
brmassa
committed
fix: CS8603 check for null before using it
brmassa
committed
fix: several null checks
brmassa
committed
fix: CS8605 checking possible null on casting
brmassa
committed
fix: call Dispose() directly is obsolete. Using .Destroy()
brmassa
committed
fix: CS8625 assigning null to non-nullable fields. most fixes are just settings them nullable
brmassa
committed
fix: null checking
brmassa
committed
refactor: readonly on several fields/properties that are never reassigned (typical for collections)
brmassa
committed
refactor: some extra fixes
brmassa
committed
Revert "fix: call Dispose() directly is obsolete. Using .Destroy()"
brmassa
committed
fix: reverting replacement of Dispose() to Destroy()
brmassa
committed

Commits on Sep 19, 2024

Revert "refactor: readonly on several fields/properties that are never reassigned (typical for collections)"
brmassa
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix/build warnings 2024 09 15#159

Fix/build warnings 2024 09 15#159
brmassa wants to merge 31 commits intoProwlEngine:developmentfrom
brmassa:fix/build-warnings-2024-09-15

Commits on Sep 18, 2024

refactor: comment out private fields/variables that are not used

refactor: comment out private fields that are not used

fix: check of not null

fix: replace `async Task` for `void` for a method that do not use any async internally

fix: switch for a SceneViewPreferences.Instance.GridType must contain all possibilities

fix: public static int OrderlessHash<T> must ensure that T is not null because it will be the index of a dictionary

refactor: optimizing Prowl.Runtime.GUI.Spacing to reuse code

fix: assure that the t.Get is not null inside SerializedProperty.Merge

fix: KeyFrame's CompareTo and Equals methods allowing null (it will be dealt internally)

fix: comment unused field and SceneMeshData.MeshData, that are never used

fix: new InspectorWindow.CreateInstanceCustomEditor to optimized and enhance code

fix: EngineObject.FindObjectsOfType should never return null

fix: some arguments passed using `ref`instead the `in` used in the signature

fix: use `await` to wait async method to finish

fix: rename Prowl.Editor.SelectHandler's Equals to EqualsFunc to avoid name conflict

fix: using new and override to avoid conflict with inherited methods

fix: unreachable code in Prowl.Runtime.PhysicsSetting

fix: variable is assigned but its value is never used

fix: check null before using it

refactor: in `AssetsBrowserWindow.DrawFileEntry` no need to use hasSubset. just check if `subAsset` is not null

fix: CS8603 check for null before using it

fix: several null checks

fix: CS8605 checking possible null on casting

fix: call Dispose() directly is obsolete. Using .Destroy()

fix: CS8625 assigning null to non-nullable fields. most fixes are just settings them nullable

fix: null checking

refactor: readonly on several fields/properties that are never reassigned (typical for collections)

refactor: some extra fixes

Revert "fix: call Dispose() directly is obsolete. Using .Destroy()"

fix: reverting replacement of Dispose() to Destroy()

Commits on Sep 19, 2024

Revert "refactor: readonly on several fields/properties that are never reassigned (typical for collections)"

Fix/build warnings 2024 09 15#159brmassa wants to merge 31 commits intoProwlEngine:developmentProwlEngine/Prowl:developmentfrom brmassa:fix/build-warnings-2024-09-15brmassa/Prowl:fix/build-warnings-2024-09-15Copy head branch name to clipboard

Commits

Commits on Sep 18, 2024

Commits on Sep 19, 2024

Fix/build warnings 2024 09 15#159
brmassa wants to merge 31 commits intoProwlEngine:developmentfrom
brmassa:fix/build-warnings-2024-09-15