Skip to content

🧑‍💻 ブロックに引っかかる前進ライブラリを実装#2236

Merged
haiiro2gou merged 5 commits intomasterfrom
dev/komaramune_slide_move
Mar 7, 2026
Merged

🧑‍💻 ブロックに引っかかる前進ライブラリを実装#2236
haiiro2gou merged 5 commits intomasterfrom
dev/komaramune_slide_move

Conversation

@komaramune
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 19, 2026 17:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a new slide move library (lib:slide_move/) that moves entities forward while handling block collisions. The implementation is similar to the existing lib:reflection_bullet/ library but designed for sliding movement along obstacles rather than reflection.

Changes:

  • Added main API function for slide move with argument validation and cleanup
  • Implemented collision detection and movement geometry logic using macro functions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
TheSkyBlessing/data/lib/functions/slide_move/.mcfunction Main API entry point with argument validation, default value handling, and storage cleanup
TheSkyBlessing/data/lib/functions/slide_move/core/geometry.m.mcfunction Core movement logic with axis-based collision detection and entity teleportation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread TheSkyBlessing/data/lib/functions/slide_move/core/geometry.m.mcfunction Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread TheSkyBlessing/data/lib/functions/slide_move/.mcfunction Outdated
Comment thread TheSkyBlessing/data/lib/functions/slide_move/.mcfunction Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread TheSkyBlessing/data/lib/functions/slide_move/.mcfunction
Comment thread TheSkyBlessing/data/lib/functions/slide_move/.mcfunction
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@haiiro2gou haiiro2gou changed the title ブロックに引っかかる前進ライブラリを実装 🧑‍💻 ブロックに引っかかる前進ライブラリを実装 Mar 7, 2026
@haiiro2gou haiiro2gou merged commit fdee1ee into master Mar 7, 2026
10 checks passed
@haiiro2gou haiiro2gou deleted the dev/komaramune_slide_move branch March 7, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants