Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a cone-shaped bounding volume detection library for Minecraft entities. The implementation allows users to detect entities within a conical region defined by an apex point, axis direction, and apex angle.
- Adds a new public API (
lib:bounding_cone/) for cone-shaped collision detection - Implements geometric calculations using trigonometry and entity rotation manipulation
- Uses a macro-based detection system similar to the existing
bounding_fanlibrary
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
TheSkyBlessing/data/lib/functions/bounding_cone/.mcfunction |
Main API entry point with argument validation and documentation for the cone detection system |
TheSkyBlessing/data/lib/functions/bounding_cone/core/calc.mcfunction |
Core calculation logic that computes sin(angle/4) and prepares data for macro-based detection |
TheSkyBlessing/data/lib/functions/bounding_cone/core/detect.m.mcfunction |
Macro function that performs geometric detection using entity positioning and rotation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EllaCoat
approved these changes
Dec 30, 2025
Contributor
EllaCoat
left a comment
There was a problem hiding this comment.
こまさんに聞きながらコマンドチェックを行った所、コマンド自体にミスは見られなかったため、私はApproveをします。
Contributor
|
とりあえず、はいいろ氏辺りに今度見てもらって大丈夫そうなら使おうかな。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.