Skip to content

円錐型当たり判定ライブラリの実装#2211

Open
komaramune wants to merge 2 commits intomasterfrom
dev/komaramune_bounding_cone
Open

円錐型当たり判定ライブラリの実装#2211
komaramune wants to merge 2 commits intomasterfrom
dev/komaramune_bounding_cone

Conversation

@komaramune
Copy link
Contributor

No description provided.

@komaramune komaramune requested a review from ChenCMD as a code owner December 30, 2025 09:52
Copilot AI review requested due to automatic review settings December 30, 2025 09:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a cone-shaped bounding volume detection library for Minecraft entities. The implementation allows users to detect entities within a conical region defined by an apex point, axis direction, and apex angle.

  • Adds a new public API (lib:bounding_cone/) for cone-shaped collision detection
  • Implements geometric calculations using trigonometry and entity rotation manipulation
  • Uses a macro-based detection system similar to the existing bounding_fan library

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
TheSkyBlessing/data/lib/functions/bounding_cone/.mcfunction Main API entry point with argument validation and documentation for the cone detection system
TheSkyBlessing/data/lib/functions/bounding_cone/core/calc.mcfunction Core calculation logic that computes sin(angle/4) and prepares data for macro-based detection
TheSkyBlessing/data/lib/functions/bounding_cone/core/detect.m.mcfunction Macro function that performs geometric detection using entity positioning and rotation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@EllaCoat EllaCoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こまさんに聞きながらコマンドチェックを行った所、コマンド自体にミスは見られなかったため、私はApproveをします。

@EllaCoat
Copy link
Contributor

とりあえず、はいいろ氏辺りに今度見てもらって大丈夫そうなら使おうかな。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants