Skip to content

fix the quick issue with the text at the end of conservation but not dup stats #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinW1998 merged 2 commits into from
Apr 21, 2025
Merged

fix the quick issue with the text at the end of conservation but not dup stats #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32696c2
fix the quick issue with the strange thing at the end of conservation…
romaniac01 Apr 20, 2025
0389685
Merge branch 'ProjectCeleste:master' into master
romaniac01 Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 1 addition & 34 deletions src/Extension/EconTraitExt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,40 +264,7 @@ public static string GetDisplayNameLocalized(this EconTraitXmlEffect effect, ILa
}
case EffectSubTypeEnum.Yield:
{
switch (effect.UnitType)
{
case EffectUnitTypeEnum.AbstractFruit:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.AbstractFarm:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.AbstractFish:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.Fish:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.Herdable:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.Huntable:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.Tree:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.Gold:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
case EffectUnitTypeEnum.Stone:
return
languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
default:
//Instead of throw excemption, I put a default text.
return languages["stringtablex"][language][300046].Text.Replace(" +%1.1f", string.Empty) + ":";
//throw new ArgumentOutOfRangeException(nameof(effect.UnitType), effect.UnitType, null);
}
return languages["stringtablex"][language][300046].Text.Replace(" %s%.1f%%", string.Empty) + ":";
}
case EffectSubTypeEnum.HitPercentDamageMultiplier:
{
Expand Down