feat: complete Sparkctl CLI command surface#9
Conversation
- documents synthetic-only SPARK hackathon boundaries - adds replay failure labels EVIDENCE_LOSS and CONSTRAINT_DRIFT - documents canonical JSON, ledger/hash chain checks, and verify-before-replay - marks XENTRY/OBD and legacy compression concepts as future-only exclusions - removes hardcoded legacy local path assumptions from active governance docs - Rust validation not run due Windows NUL ACL executor issue; no Rust source changed
There was a problem hiding this comment.
Code Review
This pull request fully wires up the agy-ct CLI subcommands (including package compression, verification, replay, adversarial checks, and notebook bundling), implements structured error mapping (EVIDENCE_LOSS, CONSTRAINT_DRIFT) with ledger validation, separates replay output streams, and adds extensive integration tests and documentation for the SPARK Hackathon. The reviewer feedback is highly constructive and identifies critical path-handling bugs (such as empty parent paths when outputting to plain filenames), potential race conditions in temporary file generation, and a violation of the project's robust error handling standards due to an unsafe .unwrap() call.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Completes the local Sparkctl CLI command surface and synchronizes the project documentation.
CLI command surface
All known CLI placeholders are now wired and documented:
agy-ct package compressagy-ct package adversarialagy-ct report exportagy-ct notebook bundleImplemented backend modules
report_export::runfor Markdown report export from JSON reportsnotebook_bundle::runfor nbformat v4.ipynbbundle export from context JSON and optional render textDocumentation sync
README.mdin German with current command status, matrix, Mermaid pipeline, integrity explanation, and non-claims boundaries.docs/SPARK_ALIGNMENT.mdwith the final wired command list and test status..antigravity/anddocs/context/assets from the earlier Antigravity config branch without reintroducing obsolete README drift.Validation
Local validation reported:
cargo fmt --all --checkpassedcargo check --testspassedSafety / claim hygiene
PR hygiene notes
.antigravity/anddocs/context/assets from PR docs: add Antigravity config and fix README drift #8.paper-hf-prep) untouched because it is orthogonal Paper/Hugging Face draft material.