[45885] Start Timer Event configuration affected by the user's profile date format#465
Open
marcoAntonioNina wants to merge 3 commits intodevelopfrom
Open
[45885] Start Timer Event configuration affected by the user's profile date format#465marcoAntonioNina wants to merge 3 commits intodevelopfrom
marcoAntonioNina wants to merge 3 commits intodevelopfrom
Conversation
rodriquelca
reviewed
Sep 9, 2025
src/components/FormDatePicker.vue
Outdated
| }, | ||
| format() { | ||
| return this.datepicker ? getUserDateTimeFormat() : getUserDateFormat(); | ||
| let format = this.datepicker ? getUserDateTimeFormat() : getUserDateFormat(); |
Contributor
There was a problem hiding this comment.
add a fallback control
format = format || 'YYYY-MM-DD'; // fallback
Contributor
Author
There was a problem hiding this comment.
the functions getUserDateTimeFormat() and getUserDateFormat() already have a fallback defined.
src/components/FormDatePicker.vue
Outdated
| const hasTimePattern = /[Hh]{1,2}:[mM]{1,2}/.test(format); | ||
| if (!hasTimePattern) { | ||
| // If forceDateTime is true and no time pattern exists, ensure the format includes hh:mm A | ||
| format = format.replace(/[\sHh:msaAzZ]/g, '') + ' hh:mm A'; |
Contributor
There was a problem hiding this comment.
is posible use
format =${format} hh:mm A;
instead of replace?
marcoAntonioNina
force-pushed
the
bugfix/FOUR-25088
branch
from
f4b84c9 to
7879400
Compare
rodriquelca
approved these changes
Sep 9, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket FOUR-25088
According to the date picker configuration, if it is a datetime type, a hh:mm is added by default if the date and time configuration does not have the time.