Fix File Persistence on Page Reload for Single and Multiple File Uploads#1758
Open
sanjacornelius wants to merge 2 commits intorelease-2024-summerfrom
Open
Fix File Persistence on Page Reload for Single and Multiple File Uploads#1758sanjacornelius wants to merge 2 commits intorelease-2024-summerfrom
sanjacornelius wants to merge 2 commits intorelease-2024-summerfrom
Conversation
screen-builder
|
||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
bugfix/FOUR-19799
|
| Run status |
|
| Run duration | 07m 21s |
| Commit |
|
| Committer | Sanja |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
19
|
|
|
0
|
|
|
295
|
| View all changes introduced in this branch ↗︎ | |
marcoAntonioNina
approved these changes
Oct 25, 2024
d619975 to
fb41ba0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue & Reproduction Steps
This PR addresses two key issues related to file persistence within File Upload components in Screen Builder:
The solution introduces a
fetchFilefunction, which retrieves uploaded files by their ID on component mount ifthis.valueexists, providing consistent file persistence across reloads.Changes:
fetchFilelogic to retrieve uploaded files by ID whenthis.valueis present during component mount.How to Test:
package-versionsinstalled to utilize the Autosave functionality- Single File Upload
- Multiple File Upload
Note: Due to unsupported autosave functionality, file persistence will not work in Web Entry and Collection screens.
Related Tickets & Packages
- FOUR-19799
- FOUR-14168
Code Review Checklist