[FOUR-4875] Removed defaultValues from Advanced tab and added unselected option (4.1)#1136
Open
josechirivella wants to merge 10 commits into4.1-developfrom
Open
[FOUR-4875] Removed defaultValues from Advanced tab and added unselected option (4.1)#1136josechirivella wants to merge 10 commits into4.1-developfrom
josechirivella wants to merge 10 commits into4.1-developfrom
Conversation
added 8 commits
December 15, 2021 18:58
* Added the logic to set the correct value to the correct config * Setting it to the defaultOptionKey just in case
* Added the data-cy to the html
…l should change to avoid any bugs / error
* Organized the file and refactored some things
added 2 commits
December 22, 2021 11:40
…eturned value type was an object
josechirivella
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though we removed the defaultValue from the advance tab, we had some functionality to set the defaultValues using radio buttons next to the options, which wasn't working previously but fixed those and added some e2e
End result:
Things to test