Skip to content

FOUR-29144: Fix 404 on Process Information chart when no saved search is configured#8719

Open
eiresendez wants to merge 1 commit intodevelopfrom
bugfix/FOUR-29144
Open

FOUR-29144: Fix 404 on Process Information chart when no saved search is configured#8719
eiresendez wants to merge 1 commit intodevelopfrom
bugfix/FOUR-29144

Conversation

@eiresendez
Copy link
Contributor

Issue & Reproduction Steps

When opening Process Information for a process without a saved search chart configured, the UI attempts to call saved-searches/charts/undefined, which returns a 404.

  1. Log in.
  2. Go to Processes.
  3. Open any process without a saved search chart configured.
  4. Click the info (“i”) button to open Process Information.
  5. Observe the 404 in the network tab for saved-searches/charts/undefined.

Solution

  • Guard the chart fetch to only run when package-collections is installed and a valid chartId exists.
  • Default chartId to 0 when launchpad properties do not include saved_chart_id.

How to Test

  1. Open a process without a saved search chart configured.
  2. Click the info (“i”) button.
  3. Confirm no request is made to saved-searches/charts/undefined and no 404 appears.
  4. (Optional) Configure a saved search chart for the process and confirm the chart loads via saved-searches/charts/{id}.

ci:deploy

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-648423e69d.engk8s.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants