Fix update method.#10
Open
chriscarpenter12 wants to merge 2 commits intoProAI:masterfrom
chriscarpenter12:master
Open
Fix update method.#10chriscarpenter12 wants to merge 2 commits intoProAI:masterfrom chriscarpenter12:master
chriscarpenter12 wants to merge 2 commits intoProAI:masterfrom
chriscarpenter12:master
Conversation
Contributor
|
All data for updating is present in the Eloquent model. Why do you need an additional database call? |
Author
|
It has access to the data in the main table, but it does not contain the data for the version table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed my update method wasn't working either. It was updating the main table, but erroring out on the versioned table. Using a duplicate key of 1 for every update no matter how many versions. Looks like
getVersionColumn()needed to be changed togetLatestVersionColumn().I also added code that fetches the old version row and merges in the new updates. The way the old code was wrote it would only insert a versioned row with just the updated values, and
nullout the existing data. I believe this was the desired behavior.