Skip to content

Conversation

@rasdani
Copy link
Contributor

@rasdani rasdani commented Dec 26, 2025

Description

warn when provided system prompt or few-shot example will be ignored because prompt column being already present.
especially helpful when loading existing upstream datasets which do prompt column differently.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Adds guardrails for pre-formatted datasets.

  • In Environment._ensure_prompt, when a prompt column already exists, the provided system_prompt and few_shot are ignored and a warning is logged to inform the user

Written by Cursor Bugbot for commit 9a414ef. This will update automatically on new commits. Configure here.

@rasdani rasdani requested a review from willccbb December 26, 2025 19:34
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rasdani rasdani requested a review from mikasenghaas December 26, 2025 19:34
@rasdani rasdani merged commit 0ccb1f6 into main Dec 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants