Skip to content

Conversation

@ascholerChemeketa
Copy link
Contributor

This adds QR code generation for interactive programs (activecode/codelens).

Because programs already may have width issues in print, I don't want to do the link side by side with the program itself. So instead, an assemblage with a link/qr is added after the program. I think it is good to have that block visually separated as a "here is something not part of the core text". But I feel no real ownership of that layout.

image

I figure you will want to do your own test of generation, so no commit with the updated QR codes.

First commit fixes a breaking bug if version 8+ of qrcode is installed:
https://pypi.org/project/qrcode/
If the rest of this ends up languishing, it might be worth breaking that commit out.

@ascholerChemeketa
Copy link
Contributor Author

BTW - I hate that the url needs to go in a p and thus gets indented. Not sure how to avoid that though.

@ascholerChemeketa
Copy link
Contributor Author

Draft while working on:
#2682

@ascholerChemeketa ascholerChemeketa marked this pull request as draft August 26, 2025 21:10
@ascholerChemeketa ascholerChemeketa marked this pull request as ready for review August 31, 2025 17:33
@ascholerChemeketa
Copy link
Contributor Author

Updated based on results of <pi:localize> work.

Content since last review:

  • Individual xml sidecar files for urls
  • Use pi:localize
  • Dropped commit moving static-url templates from -assembly to -html (see below)

I kept the extraction-wrapper override in extract-qrcode as it is the best way to have a single decision based on $baseurl to either generates error message or do work.

I believe dataurl is the now the only thing that still relies on "static-url" templates during static build. So moving the "static-url" templates needs to wait on a solution for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant