Add push_type argument for client.send_notification#118
Open
namrata93 wants to merge 1 commit intoPr0Ger:masterfrom
Open
Add push_type argument for client.send_notification#118namrata93 wants to merge 1 commit intoPr0Ger:masterfrom
namrata93 wants to merge 1 commit intoPr0Ger:masterfrom
Conversation
Owner
|
Hi Thanks for contribution! Can you fix indentation to not use mixed tab/spaces? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a push_type argument to client.send_notification. Currently I have to make use of the code to deduce the push_type from the topic, which is forcing me to create a topic when I think it's easier to just pass in the push_type
This argument is already present in the method client.send_notification_batch so simply mimicking it.