WIP: Update ContainerRegistry code to use ORAS.NET

.ci/ci.yml

@@ -69,7 +69,7 @@ stages:
         Write-Verbose -Verbose "Importing build utilities (buildtools.psd1)"
         Import-Module -Name $(Build.SourcesDirectory)/buildtools.psd1 -Force
         #
-        $(Build.SourcesDirectory)/build.ps1 -Build -Clean -BuildConfiguration Release -BuildFramework 'net472'
+        $(Build.SourcesDirectory)/build.ps1 -Build -Clean -BuildConfiguration Release -BuildFramework 'net8.0'
       displayName: Build Module
 
     - pwsh: |

.ci/ci_auto.yml

@@ -68,8 +68,8 @@ stages:
         Write-Verbose -Verbose "Importing build utilities (buildtools.psd1)"
         Import-Module -Name $(Build.SourcesDirectory)/buildtools.psd1 -Force
         #
-        # Build for net472 framework
-        $(Build.SourcesDirectory)/build.ps1 -Build -Clean -BuildConfiguration Release -BuildFramework 'net472'
+        # Build for net8.0 framework
+        $(Build.SourcesDirectory)/build.ps1 -Build -Clean -BuildConfiguration Release -BuildFramework 'net8.0'
       displayName: Build module
 
     - pwsh: |

build.ps1

@@ -23,8 +23,8 @@ param (
     [ValidateSet("Debug", "Release")]
     [string] $BuildConfiguration = "Debug",
 
-    [ValidateSet("net472")]
-    [string] $BuildFramework = "net472"
+    [ValidateSet("net8.0")]
+    [string] $BuildFramework = "net8.0"
 )
 
 Import-Module -Name "$PSScriptRoot/buildtools.psd1" -Force

doBuild.ps1

@@ -89,8 +89,12 @@ function DoBuild
                 'Azure.Core'
                 'Azure.Identity'
                 'Microsoft.Bcl.AsyncInterfaces'
+                'Microsoft.Extensions.Caching.Abstractions'
+                'Microsoft.Extensions.Caching.Memory'
                 'Microsoft.Extensions.FileProviders.Abstractions'
                 'Microsoft.Extensions.FileSystemGlobbing'
+                'Microsoft.Extensions.Logging.Abstractions'
+                'Microsoft.Extensions.Options'
                 'Microsoft.Extensions.Primitives'
                 'Microsoft.Identity.Client'
                 'Microsoft.Identity.Client.Extensions.Msal'
@@ -107,20 +111,9 @@ function DoBuild
                 'NuGet.ProjectModel'
                 'NuGet.Protocol'
                 'NuGet.Versioning'
-                'System.Buffers'
-                'System.Diagnostics.DiagnosticSource'
-                'System.IO.FileSystem.AccessControl'
+                'OrasProject.Oras'
                 'System.Memory.Data'
-                'System.Memory'
-                'System.Numerics.Vectors'
-                'System.Runtime.CompilerServices.Unsafe'
-                'System.Security.AccessControl'
                 'System.Security.Cryptography.ProtectedData'
-                'System.Security.Principal.Windows'
-                'System.Text.Encodings.Web'
-                'System.Text.Json'
-                'System.Threading.Tasks.Extensions'
-                'System.ValueTuple'
             )
 
             $buildSuccess = $true

src/code/FindHelper.cs

@@ -9,6 +9,7 @@
 using System.Management.Automation;
 using System.Net;
 using System.Runtime.ExceptionServices;
+using System.Runtime.InteropServices;
 using System.Text.RegularExpressions;
 using System.Threading;
 
@@ -188,7 +189,11 @@ public IEnumerable<PSResourceInfo> FindByResourceName(
             {
                 PSRepositoryInfo currentRepository = repositoriesToSearch[i];
 
-                bool isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+                bool isAllowed = true;
+                if (System.Runtime.InteropServices.RuntimeInformation.IsOSPlatform(System.Runtime.InteropServices.OSPlatform.Windows))
+                {
+                    isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+                }
 
                 if (!isAllowed)
                 {
@@ -376,7 +381,12 @@ public IEnumerable<PSCommandResourceInfo> FindByCommandOrDscResource(
             {
                 PSRepositoryInfo currentRepository = repositoriesToSearch[i];
 
-                bool isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+                bool isAllowed = true;
+
+                if (OperatingSystem.IsWindows())
+                {
+                    isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+                }
 
                 if (!isAllowed)
                 {
@@ -583,7 +593,12 @@ public IEnumerable<PSResourceInfo> FindByTag(
             {
                 PSRepositoryInfo currentRepository = repositoriesToSearch[i];
 
-                bool isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+
+                bool isAllowed = true;
+                if (OperatingSystem.IsWindows())
+                {
+                    isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+                }
 
                 if (!isAllowed)
                 {
@@ -701,7 +716,7 @@ private IEnumerable<PSResourceInfo> SearchByNames(ServerApiCall currentServer, R
                         _cmdletPassedIn.WriteDebug("No version specified, package name is '*'");
                         // Example: Find-PSResource -Name "*"
 
-                        // Note: Just for resources from V2 servers, specifically PSGallery, if the resource is unlisted and was requested non-explicitly 
+                        // Note: Just for resources from V2 servers, specifically PSGallery, if the resource is unlisted and was requested non-explicitly
                         // (i.e requested name has wildcard) the resource should not be returned and ResponseUtil.ConvertToPSResourceResult() call needs to be informed of this.
                         // In all other cases, return the resource regardless of whether it was requested explicitly or not.
                         bool isResourceRequestedWithWildcard = isV2Resource;
@@ -752,7 +767,7 @@ private IEnumerable<PSResourceInfo> SearchByNames(ServerApiCall currentServer, R
                         // Example: Find-PSResource -Name "Az*" -Tag "Storage"
                         _cmdletPassedIn.WriteDebug("No version specified, package name contains a wildcard.");
 
-                        // Note: Just for resources from V2 servers, specifically PSGallery, if the resource is unlisted and was requested non-explicitly 
+                        // Note: Just for resources from V2 servers, specifically PSGallery, if the resource is unlisted and was requested non-explicitly
                         // (i.e requested name has wildcard) the resource should not be returned and ResponseUtil.ConvertToPSResourceResult() call needs to be informed of this.
                         // In all other cases, return the resource regardless of whether it was requested explicitly or not.
                         bool isResourceRequestedWithWildcard = isV2Resource;
@@ -1173,7 +1188,7 @@ internal IEnumerable<PSResourceInfo> FindDependencyPackages(
                     }
                     else if(dep.VersionRange.MaxVersion != null && dep.VersionRange.MinVersion != null && dep.VersionRange.MaxVersion.OriginalVersion.Equals(dep.VersionRange.MinVersion.OriginalVersion))
                     {
-                        string depPkgVersion = dep.VersionRange.MaxVersion.OriginalVersion; 
+                        string depPkgVersion = dep.VersionRange.MaxVersion.OriginalVersion;
                         FindResults responses = currentServer.FindVersion(dep.Name, version: dep.VersionRange.MaxVersion.ToNormalizedString(), _type, out ErrorRecord errRecord);
                         if (errRecord != null)
                         {

src/code/GroupPolicyRepositoryEnforcement.cs

@@ -6,6 +6,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Runtime.Versioning;
 using Microsoft.PowerShell.PSResourceGet.UtilClasses;
 using Microsoft.Win32;
 
@@ -14,6 +15,7 @@ namespace Microsoft.PowerShell.PSResourceGet.Cmdlets
     /// <summary>
     /// This class is used to enforce group policy for repositories.
     /// </summary>
+    [SupportedOSPlatform("windows")]
     public class GroupPolicyRepositoryEnforcement
     {
         const string userRoot = "HKEY_CURRENT_USER";
@@ -29,6 +31,7 @@ private GroupPolicyRepositoryEnforcement()
         /// </summary>
         ///
         /// <returns>True if the group policy is enabled, false otherwise.</returns>
+        [SupportedOSPlatform("windows")]
         public static bool IsGroupPolicyEnabled()
         {
             if (Environment.OSVersion.Platform != PlatformID.Win32NT)
@@ -57,6 +60,7 @@ public static bool IsGroupPolicyEnabled()
         /// </summary>
         /// <returns>Array of allowed URIs.</returns>
         /// <exception cref="InvalidOperationException">Thrown when the group policy is not enabled.</exception>
+        [SupportedOSPlatform("windows")]
         public static Uri[]? GetAllowedRepositoryURIs()
         {
             if (Environment.OSVersion.Platform != PlatformID.Win32NT)
@@ -92,6 +96,7 @@ public static bool IsGroupPolicyEnabled()
             }
         }
 
+        [SupportedOSPlatform("windows")]
         internal static bool IsRepositoryAllowed(Uri repositoryUri)
         {
             bool isAllowed = false;
@@ -113,6 +118,7 @@ internal static bool IsRepositoryAllowed(Uri repositoryUri)
             return isAllowed;
         }
 
+        [SupportedOSPlatform("windows")]
         private static List<KeyValuePair<string, Uri>>? ReadGPFromRegistry()
         {
             List<KeyValuePair<string, Uri>> allowedRepositories = new List<KeyValuePair<string, Uri>>();
@@ -169,7 +175,13 @@ internal static bool IsRepositoryAllowed(Uri repositoryUri)
                                     throw new InvalidOperationException("Invalid registry value.");
                                 }
 
-                                string valueString = value.ToString();
+                                string? valueString = value.ToString();
+
+                                if (string.IsNullOrEmpty(valueString))
+                                {
+                                    throw new InvalidOperationException("Invalid registry value.");
+                                }
+
                                 var kvRegValue = ConvertRegValue(valueString);
                                 allowedRepositories.Add(kvRegValue);
                             }

src/code/InstallHelper.cs

@@ -270,7 +270,12 @@ private List<PSResourceInfo> ProcessRepositories(
             {
                 PSRepositoryInfo currentRepository = listOfRepositories[i];
 
-                bool isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+                bool isAllowed = true;
+
+                if (OperatingSystem.IsWindows())
+                {
+                    isAllowed = GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(currentRepository.Uri);
+                }
 
                 if (!isAllowed)
                 {
@@ -659,7 +664,7 @@ private List<PSResourceInfo> InstallPackages(
                             ErrorCategory.InvalidOperation,
                             _cmdletPassedIn));
 
-                    throw e;
+                    throw;
                 }
                 finally
                 {

src/code/Microsoft.PowerShell.PSResourceGet.csproj

@@ -8,8 +8,8 @@
     <AssemblyVersion>1.1.0.1</AssemblyVersion>
     <FileVersion>1.1.0.1</FileVersion>
     <InformationalVersion>1.1.0.1</InformationalVersion>
-    <TargetFrameworks>net472</TargetFrameworks>
-    <LangVersion>9.0</LangVersion>
+    <TargetFrameworks>net8.0</TargetFrameworks>
+    <LangVersion>12.0</LangVersion>
     <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
   </PropertyGroup>
 
@@ -21,12 +21,12 @@
     <PackageReference Include="NuGet.ProjectModel" Version="6.9.1" />
     <PackageReference Include="NuGet.Protocol" Version="6.9.1" />
     <PackageReference Include="PowerShellStandard.Library" Version="7.0.0-preview.1" />
-    <PackageReference Include="System.Net.Http" Version="4.3.4" />
     <PackageReference Include="System.Text.Json" Version="8.0.6" />
     <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
     <PackageReference Include="Azure.Identity" Version="1.14.2" />
+    <PackageReference Include="OrasProject.Oras" Version="0.5.0" />
+    <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.1" />
     <PackageReference Include="System.Security.Cryptography.Pkcs" Version="6.0.5" />
-    <Reference Include="System.Web" />
   </ItemGroup>
 
   <ItemGroup>