Fix unnecessary elevation on export Microsoft.Windows/FirewallRuleList#1525
Open
Gijsreyn wants to merge 1 commit intoPowerShell:mainfrom
Open
Fix unnecessary elevation on export Microsoft.Windows/FirewallRuleList#1525Gijsreyn wants to merge 1 commit intoPowerShell:mainfrom
Microsoft.Windows/FirewallRuleList#1525Gijsreyn wants to merge 1 commit intoPowerShell:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the manifest-enforced elevation requirement for the export operation of the Microsoft.Windows/FirewallRuleList DSC resource so firewall rule enumeration can run non-elevated, matching the resource’s read-only implementation and addressing issue #1524.
Changes:
- Dropped
requireSecurityContext: "elevated"from the resource manifest’sexportoperation. - Updated Pester tests to run export validation on Windows without requiring an elevated session.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| resources/windows_firewall/windows_firewall.dsc.resource.json | Removes the export-time elevation requirement from the resource manifest. |
| resources/windows_firewall/tests/windows_firewall_export.tests.ps1 | Removes elevation-based skipping so export behavior is validated in non-elevated Windows runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request removes the unnecessary
requireSecurityContexton export forMicrosoft.Windows/FirewallRuleListDSC resource.PR Context
Fixes #1524