fix: Cloudflare detection and context augmentation#370
Open
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
daniloc
changed the title
edwinyjlim
approved these changes
Apr 2, 2026
Comment on lines
+31
to
+33
| const packageJsonPath = path.join(installDir, 'package.json'); | ||
| const content = fs.readFileSync(packageJsonPath, 'utf-8'); | ||
| const packageJson = JSON.parse(content); |
Member
There was a problem hiding this comment.
can reuse the tryGetPackageJson util function
import { tryGetPackageJson } from '../utils/setup-utils';
const packageJson = await tryGetPackageJson({ installDir });
Comment on lines
+10
to
+11
| * 1. wrangler.toml / wrangler.jsonc / wrangler.json in project root | ||
| * 2. Cloudflare adapter packages in dependencies (@react-router/cloudflare, |
Member
There was a problem hiding this comment.
wanna add tests in src/lib/__tests__ that validates this script against these two Cloudflare criteria?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect if the user project depends on Cloudflare and provide guidance on how to integrate successfully, loaded from context-mill.