-
Notifications
You must be signed in to change notification settings - Fork 53
feat: Allow customization of socket options #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows clients to configure (e.g.) socket keep alive probes
2ffcf66 to
3eb1610
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 3 comments
dmarticus
approved these changes
Dec 9, 2025
Contributor
dmarticus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job finding this; I'm impressed that you tracked this down.
In addition to my comments, 2 more questions:
- Given that the specific use case around this is AWS NAT timeouts (and I imagine this might also apply to azure/gcp load balancers as well), can we document this in the options as well?
- Should
enable_keep_alive()be idempotent? Currently calling it twice rebuilds the session unnecessarily.
Disables connection pooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
enable_keep_alive()andset_socket_options()to configure TCP keepalive on HTTP connections, preventing idle connections from being dropped by network infrastructure.Additionally adds
disable_connection_reuse()to prevent connection pooling altogether.Usage
Or with custom socket options:
Testing
If you'd like to try this branch, install it to your project.
requirements.txt
pyproject.toml (Poetry):
pyproject.toml (pip/setuptools):